Implement modal.onFailure without using jquery #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
onFailure-no-jquery
branch
2 times, most recently
from
7f8b95a
to
4119ccf
Compare
dkinzer
reviewed
Dec 10, 2021
Comment on lines
342
to
344
| // const domparser = new DOMParser(); | ||
| // const dom = domparser.parseFromString(contents, "text/html") | ||
| // const nodes = dom.querySelectorAll('body > *') |
There was a problem hiding this comment.
@jcoyne is this left here for documentation purposes?
There was a problem hiding this comment.
Oops, this is cruft. I'll pull it.
There was a problem hiding this comment.
The files in app/assets/javascript are just compiled versions (using npm run js-compile-bundle) of what is in app/javascript. In this instance I didn't recompile after changing src.
There was a problem hiding this comment.
I recompiled and pushed the results up. That had the effect of removing these old comments.
jcoyne
force-pushed
the
onFailure-no-jquery
branch
from
4119ccf
to
7c25fc7
Compare
dkinzer
approved these changes
Dec 10, 2021
jcoyne
force-pushed
the
onFailure-no-jquery
branch
from
7c25fc7
to
a8a6b65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.