Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase search bar component #2604

Merged
merged 5 commits into from
Jan 18, 2022
Merged

Rebase search bar component #2604

merged 5 commits into from
Jan 18, 2022

Conversation

barmintor
Copy link
Contributor

@barmintor barmintor commented Jan 16, 2022 •
edited
Loading

Attempting to rebase branch from #2468

@barmintor barmintor force-pushed the rebase_search-bar-component branch 3 times, most recently from 5c75a02 to 7c513ef Compare January 17, 2022 14:47
@barmintor barmintor marked this pull request as ready for review January 17, 2022 19:18
@barmintor barmintor requested a review from cbeer January 17, 2022 19:19
@barmintor
Copy link
Contributor Author

@cbeer the rebase took me a bit, but your proposed change to use a preferred idiom seems in-line with project goals. I'm requesting your review here to affirm that I've maintained your original intent. This should merge cleanly, and if so we can close #2468 .

@barmintor barmintor mentioned this pull request Jan 17, 2022
Closed
cbeer
cbeer approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@cbeer cbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM. It's originally my code, so I'll let someone else merge.

@jcoyne jcoyne merged commit c4f4155 into projectblacklight:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeer cbeer cbeer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@barmintor @cbeer @jcoyne