Add collations to did you mean #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@barmintor this looks great, thank you for taking this on. Honestly, what I did was kind of a "late night make this work for a demo tomorrow" level code, so this looks great. I'll close my PR in favour of this one! |
|
Awesome, thanks for getting back to me! I'll remove the draft tag. |
tpendragon
approved these changes
Feb 9, 2022
|
thanks for the merge @tpendragon |
jcoyne
added a commit
that referenced
this pull request
Feb 25, 2022
Backport #2605 (Support for spellcheck collations)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@epugh this is a rebase of your branch for collations, with some rudimentary tests added to ensure the existing API was satisfied and as well as your changes. Since @bess reviewed the original PR #2472 , I think there's consensus regarding the use case, but @jcoyne raised good questions about specs - there was a departure from intended behavior in the PR (and from the coverage goals we have for the project).
It would have been a bit more daunting to write the specs on the original PR, but since it was opened a spec for
Blacklight::Response::SpellcheckComponentwas merged to main, so now it's only a matter of adding to a couple of existing spec suites. Please let me know if you have any questions about the additional commits, but if you're satisfied that your use case is covered I'll remove the draft tag from this PR.