Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the class_methods module provided by ActiveSupport::Concern #2632

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Feb 25, 2022

This is the documented way of using AS::Concern, using the ClassMethods module seems to rely on an undocumented implementation detail.

This is the documented way of using AS::Concern, using the ClassMethods module seems to rely on an undocumented implementation detail.
@cbeer
Copy link
Member

cbeer commented Feb 25, 2022

Seems like class_methods came in with Rails 4.2. It's probably time we start using it too 😬

@cbeer cbeer merged commit 625d15f into main Feb 25, 2022
@cbeer cbeer deleted the class-methods branch February 25, 2022 14:47
@cbeer cbeer added the Backport label Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants