Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the _previous_next_doc.html.erb partial in 7.x #2711

Merged
merged 2 commits into from
May 9, 2022

Commits on May 7, 2022

  1. Deprecate the _previous_next_doc.html.erb partial

    Complaints have been made about how challenging it is to follow program execution through various partials, helpers and components.  I identified that the _previous_next_doc.html.erb partial does nothing but render a component. We can remove this partial and make it easier for people reading the code to follow the control flow.
    jcoyne authored and barmintor committed May 7, 2022
    Configuration menu
    Copy the full SHA
    412331d View commit details
    Browse the repository at this point in the history

Commits on May 8, 2022

  1. Deprecate render_document_main_content_partial helper

    All this method does is call a partial
    
    To make the program flow easier to understand, we can just render the partial and avoid the helper call.
    jcoyne authored and barmintor committed May 8, 2022
    Configuration menu
    Copy the full SHA
    72d5040 View commit details
    Browse the repository at this point in the history