Use the DocumentMetadataComponent to render email + sms fields #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
force-pushed
the
email-sms-component
branch
3 times, most recently
from
4413578
to
bdc7d33
Compare
cbeer
force-pushed
the
email-sms-component
branch
from
bdc7d33
to
745a9ce
Compare
cbeer
force-pushed
the
email-sms-component
branch
from
745a9ce
to
616ee85
Compare
cbeer
force-pushed
the
email-sms-component
branch
2 times, most recently
from
589ecb6
to
e95e2cf
Compare
cbeer
force-pushed
the
email-sms-component
branch
from
e95e2cf
to
8b1f4ad
Compare
jcoyne
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings email and SMS notifications into the same metadata field rendering process that's used for rendering the HTML pages. Previously, the email and SMS fields were hard-coded (and then loosely configurable, but without the power of metadata value display)