Restore the wrapping blacklight-icons span to componentized icons #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
force-pushed
the
icon-components
branch
2 times, most recently
from
6af6c22
to
a796a4b
Compare
bess
approved these changes
Oct 17, 2022
jcoyne
requested changes
Oct 17, 2022
jcoyne
reviewed
Oct 17, 2022
cbeer
force-pushed
the
icon-components
branch
from
a796a4b
to
77ab8a9
Compare
jcoyne
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2670 , we added support for component-supplied icons to avoid a hard dependency on sprockets (which... turns out not to be going away, 🤷♂️ ). I'm not sure why the wrapping
.blackight-iconsspan was dropped, but it's heavily used in e.g. arclight, so it seems like it'd be nice to bring back (and allow us to backport icon components to 7.x)