Remove unused bloodhound-js dependency. #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-existing code is using a `Bloodhound` object actually from alternate `typeahead.js` package, see: https://github.com/projectblacklight/blacklight/blob/v7.31.0/app/javascript/blacklight/autocomplete.js#L2 import Bloodhound from 'typeahead.js/dist/bloodhound.js' That is importing Bloodhound from typeahead.js package, not from bloodhound-js package. As far as I can tell, no use of `bloodhound-js` package is actually being made, so the dependency is unnecessary. Eliminating it will keep blacklight-consuming builds faster and smaller with simpler dependency trees.
jcoyne
approved these changes
Oct 18, 2022
|
Does anyone have any idea why CI is stalled or what can be done about it? I'm at a loss. |
|
Thanks, @jrochkind and @jcoyne ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-existing code is using a
Bloodhoundobject actually from alternatetypeahead.jspackage, see:https://github.com/projectblacklight/blacklight/blob/v7.31.0/app/javascript/blacklight/autocomplete.js#L2
That is importing Bloodhound from typeahead.js package, not from bloodhound-js package. As far as I can tell, no use of
bloodhound-jspackage is actually being made, so the dependency is unnecessary. Eliminating it will keep blacklight-consuming builds faster and smaller with simpler dependency trees.This is not relevant to
mainbranch/BL8, which has already removed both of these dependencies at 76e8833 . So it is a PR directly to release-7.x branch for future 7.x releases only.I could use confirmation of this from someone else who understands
blacklight-frontendbetter, it's new to me. @jcoyne and I discussed it a bit here: https://code4lib.slack.com/archives/C54TB5WDQ/p1666105410283619?thread_ts=1666038752.456159&cid=C54TB5WDQ