Copy the config to each new component as it is created

[jcoyne]

Fixes #2867

[jrochkind]

I don't love the amount we are customizing ViewComponent, raising the risk of breakage with ViewComponent releases (which has happened on a couple minor releases of ViewComponent I think). I think it's taken more ongoing maintenance than anticipated to keep this working.

I also worry about performance implications once we start coping/creating data structures on every instantiation as here.

Is this thing for the ability to override templates from an engine with a template in local app? (A thing that the ViewComponent maintainers specifically recommend against?) I know @barmintor has been one of the proponents of this, but I think was open to reconsidering. Is it worth reconsidering?

Or is this for some other feature?

I would rather, and would propose, we just use ViewComponent as it's maintainers intend, instead of trying to patch it to work differently, resulting in periodic breakage and requiring this kind of ongoing maintenance. Keep it simple. Do we really need features other users of the popular ViewComponent package don't, do we need them enough to add this complexity?

[barmintor]

This is a workaround for a documented issue in ViewComponent.

[barmintor]

There have been two breaking changes w/ ViewComponent minor releases: One was the promotion of an experimental API (which we were using) to actual API (hurrah!); this one is a bug related to upstream changes: ViewComponent/view_component#1565

[cbeer]

I wonder if we should use (or default to?) ViewComponent::Base.config.view_component_path instead of component_class.view_component_path? I'm not sure whether changing the config per-class is a feature?

[jcoyne]

Changed to @barmintor's implementation

[barmintor]

@jcoyne can you add a pin to s.add_dependency "view_component", '~> 2.66' in the gemspec?

[barmintor]

@cbeer that's a good question, too - though in this case, Base.config is empty, so we could approach as a separate issue?

[barmintor]

This seems like a reasonable workaround to to the upstream bug.