Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Expose the original, uncompiled assets in importmaps" #2914

Merged
merged 1 commit into from Nov 18, 2022

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Nov 18, 2022

This reverts commit b682c57.

The uncompiled assets make relative imports like:

import CheckboxSubmit from './checkbox_submit'

When this is used in a live site we would want it to be:

import CheckboxSubmit from 'blacklight/checkbox_submit'

So there would still be some needed precompilation step before importmap could use the individual modules.

@cbeer cbeer merged commit 26a0b61 into main Nov 18, 2022
@cbeer cbeer deleted the revert-importmap branch November 18, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants