Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport fixes #2929

Merged
merged 7 commits into from
Dec 8, 2022
Merged

Backport fixes #2929

merged 7 commits into from
Dec 8, 2022

Commits on Dec 2, 2022

  1. Add a javascript test for bookmark checkboxes

    @cbeer
    cbeer committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    62a9e88 View commit details
    Browse the repository at this point in the history

  2. Add special handling to add document titles to the json

    @cbeer
    cbeer committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    d7c2184 View commit details
    Browse the repository at this point in the history

  3. Update documentation for Bookmarks#create

    @jcoyne @cbeer
    jcoyne authored and cbeer committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    ce46050 View commit details
    Browse the repository at this point in the history

  4. Use an inline script to remove the .no-js class to avoid an unstyled … 

    …flash of content
    @cbeer
    cbeer committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    63a49fc View commit details
    Browse the repository at this point in the history

  5. Improve non-javascript facet display

    @cbeer
    cbeer committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    b60f4e5 View commit details
    Browse the repository at this point in the history

  6. Use :focus-within selector to better approximate the javascript-enabl… 

    …ed dropdown menu
    @cbeer
    cbeer committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    43663a3 View commit details
    Browse the repository at this point in the history

  7. Add data-turbo-track attributes 

    This is what is currently generated by rails.

See https://guides.rubyonrails.org/asset_pipeline.html\#coding-links-to-assets
    @jcoyne @cbeer
    jcoyne authored and cbeer committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    320859d View commit details
    Browse the repository at this point in the history