Don't include helpers on the views #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
no-helpers-on-views
branch
3 times, most recently
from
663863d
to
1c8961a
Compare
jcoyne
force-pushed
the
no-helpers-on-views
branch
from
1c8961a
to
0a82062
Compare
marlo-longley
approved these changes
Dec 14, 2022
cbeer
reviewed
Dec 14, 2022
jcoyne
force-pushed
the
no-helpers-on-views
branch
2 times, most recently
from
13df22f
to
0590c36
Compare
This causes blacklight to pollute views that do not need these methods and it makes it confusing if a user is trying to override the helper methods, but they do not also override the views
jcoyne
force-pushed
the
no-helpers-on-views
branch
from
0590c36
to
b839ef7
Compare
thatbudakguy
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes blacklight to pollute views that do not need these methods and it makes it confusing if a user is trying to override the helper methods, but they do not also override the views