Provide a deprecation for calling show_fields_for with a scalar value #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be called with an Array. I found this bug when upgrading Argo, which called show_fields_for with a Symbol. This no longer worked in Blacklight 8 Fixes #2934
jcoyne
force-pushed
the
deprecate-scalar
branch
from
7ec18a3
to
7dda703
Compare
marlo-longley
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be called with an Array. I found this bug when upgrading Argo, which called show_fields_for with a Symbol. This no longer worked in Blacklight 8
Fixes #2934