Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On modals, flash messages display once #2961

Merged

Conversation

maxkadel
Copy link
Contributor

This PR only needs to be merged into the release-7.x branch, since the main branch uses a different implementation for flash messages.

On initial submit

Bookmark page displays success flash message

After dismissing first modal

Bookmark page with no flash message

After dismissing and doing a new search

Search results page with no flash message

Closes #2960

@maxkadel maxkadel requested a review from jcoyne January 25, 2023 14:39
@sandbergja
Copy link
Contributor

Thanks, @maxkadel, as well as @bess and @jcoyne for reviewing.

@sandbergja sandbergja merged commit ec9db68 into projectblacklight:release-7.x Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants