Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add carriage return to end of appended line #3032

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Mar 7, 2023

Fixes #3031

@sandbergja
Copy link
Contributor

Thanks, @jcoyne ! This got me just to my next error:

Multiple files with the same output path cannot be linked ("application.js")
In "/Users/sandbergj/tmp/search_app-fixed/app/assets/config/manifest.js" these files were linked:
  - /Users/sandbergj/tmp/search_app-fixed/app/assets/javascripts/application.js
  - /Users/sandbergj/tmp/search_app-fixed/app/javascript/application.js

If I simply remove the line //= link application.js from manifest.js, it works again.

The generator made an app using importmap-rails 1.1.5 and sprockets 4.2.0, for what it's worth.

@jcoyne
Copy link
Member Author

jcoyne commented Mar 7, 2023

I believe the double link error is because Blacklight 7.33 is not compatible with importmap, which is what rails 7 installs by default.

@jcoyne jcoyne merged commit c916bdd into release-7.x Mar 16, 2023
@jcoyne jcoyne deleted the jcoyne-patch-1 branch March 16, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants