Release 7.x backports #3071
Merged
Release 7.x backports #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to override the header component, while reusing existing components. For example, at Stanford we would like to insert a hidden third navbar that has a feedback form between the top bar and the search navbar. This will allow us to override the header component to do that.
This allows consuming app to override the helper. Fixes #2935
This allows you specify the logo text on the component
This makes it easier to swap out the default component without having to override the _show_main_content.html.erb. Additionally this provides consistency with how you can set the thubmnail_component
…atibility with subclasses
|
Thanks for some backports to 7.x! Was anyone already intending to do a 7.x release with these backports? Or are you just using directly from git and finding that sufficient? Or other? @cbeer, @jcoyne, @sandbergja , @barmintor ? I am especially interested in and excited about ViewComponent 3 in BL 7.x, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.