Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Add role=region and aria-controls to the FacetFieldComponent #3139

Merged
merged 1 commit into from Feb 1, 2024

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jan 25, 2024

This follows the example of https://www.w3.org/WAI/ARIA/apg/patterns/accordion/examples/accordion/ for setting the aria properties for an accordion type widget

This is a backport of #3129

This follows the example of https://www.w3.org/WAI/ARIA/apg/patterns/accordion/examples/accordion/ for setting the aria properties for an accordion type widget
@jcoyne jcoyne marked this pull request as ready for review January 25, 2024 16:04
@jrochkind
Copy link
Member

jrochkind commented Jan 25, 2024

If this is a backport, can you link to the PR on main branch that it backports? I find that bookkeeping can be pretty invaluable at tracing what was done, especially in cases something works out unexpectedly or needs to be debugged.

If this is not feasible now, cause it wasn't necessarily one easily identifiable PR or some other reason, cool, just say so!

@jcoyne
Copy link
Member Author

jcoyne commented Jan 25, 2024

@jrochkind Sure. I've updated the description.

@mjgiarlo mjgiarlo merged commit bdf125a into release-7.x Feb 1, 2024
11 checks passed
@mjgiarlo mjgiarlo deleted the backport-region branch February 1, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants