fix in highlights when it's not exists #556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a nil reference exception when using highlights that doesn't exists. Can occur if you are search for nothing (just hitting enter) or using only facets so there are no highlight and the object is nil
|
The code looks good, can you add a test to your pull request too? |
useful if you would like to add additional logs in your application like from which search_id the document was opened, writing searches log with after_filter and more
needed to add configuration
more options for autocomplete
increase acet.limit to 1000 in each request and requesting solr
|
I didn't think it was appropriate to fallback to the non-highlighted field if highlighting was requested. Implementors should have to explicitly request that. |
|
Changes Unknown when pulling f68c9de on alonyado:master into * on projectblacklight:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a nil reference exception when using highlights that doesn't exists.
Can occur if you are search for nothing (just hitting enter) or using only facets so there are no highlight and the object is nil