Added multi-tab search support for blacklight-4.3

[elohanlon]

Re-implemented multi-tab search logic using the latest Blacklight master. Resubmission of #552.

[cbeer]

Thanks, I'll give this one a try.

[elohanlon]

Actually, Travis is reporting a test failure (but I know why). I originally modified one of the now-gone cucumber tests, and needed to change the scope of a have_content call.

search_history_spec.rb:42 fails on:
expect(page).to_not have_content 'dang'

The problem is, it's scanning the entire page content for the word "dang", and because of the multi-tab fix, "dang" appears in a script in the < head > tag, which makes this test fail. We'd need to change the scope of this text scan so that it only includes the body tag. Is that okay?

[cbeer]

This still isn't working for me.

In tab 1, I do a search for everything.

In tab 2, I click the language facet "Tibetan" (with 6 docs), and after I choose a document, the pagination info is:

« Previous | 3 of 30 | Next »

[elohanlon]

Ah, I see what you mean. Are you trying this in Rails 4? My original commit was for Blacklight on Rails 3, but I think that Turbolinks in Rails 4 is causing a problem. It's not refreshing my script tag in the head. I've relocated the script tag to the top of the body and I think that this should fix things. I've also re-added a non-cucumber version of my spec test from before, and I modified the search_history test that was throwing a false error after my changes.

Can you try again, using my latest commit?

(Also: Since my feature requires JavaScript, the test does too. Is the Blacklight Travis setup able to handle JS tests at this point?)

[cbeer]

You called it, thanks, it seems to be working now, even with turbolinks enabled. I'd like to see if we can pare down the amount of information in the hash, and then I'm happy to get this merged.

I believe travis is configured to use phantomjs somehow. @jkeck?

[cbeer]

Blocked by #619. I'll rebase this patch on top of #619 so we're not passing around so much information (especially controller internal information). That might even let us do a non-javascript alternative too..

[elohanlon]

Sounds good!

[jcoyne]

Superseded by #619