Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes should be configurable to use something other than 'catalog' #655

Merged
merged 1 commit into from Dec 29, 2013

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Dec 12, 2013

No description provided.

@cbeer
Copy link
Member

cbeer commented Dec 13, 2013

If you used a route other than 'catalog', you'd have to override any helpers and views that are hard-coded to use that, right?

I need to check, but I think there might be some helpful information in one of our "use resourceful routing" tickets somewhere.

@ghost ghost assigned cbeer Dec 18, 2013
@jcoyne
Copy link
Member Author

jcoyne commented Dec 20, 2013

@cbeer We could really use this refactoring for a project for Tufts right now. If I rebase, do you have any further objections to merging?

Details: they are overriding the acceptable characters for :id

resources :catalog, :only => [:show, :update], :constraints => { :id => ALLOW_DOTS, :format => false }

   Blacklight::Routes.new(self, {}).catalog

But doing it this way means they loose /catalog/opensearch.xml in order to gain: /catalog/my.strange:id.chars

Allow passing id contstraints to the routes.
@cbeer
Copy link
Member

cbeer commented Dec 28, 2013

If you wanted to merge it in, I suppose that's fine. I was hoping to get a chance before our break to review this again (because it is a common local concern as well), and make sure it'd handle our local concerns as well, but I could do that on master instead.

jcoyne added a commit that referenced this pull request Dec 29, 2013
Routes should be configurable to use something other than 'catalog'
@jcoyne jcoyne merged commit 614aa89 into master Dec 29, 2013
@jcoyne jcoyne deleted the configurable_routes branch December 29, 2013 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants