line-height for constraints

[jrochkind]

When contraints wrap to two lines, they needed more space.

Fixed by increasing line-height of the .constraints-container, then had to adjust padding on other elements to leave spacing the same.

(I'm also trying to figure out a solution to when the screen is so narrow and one individual constraint so lengthy that it goes off screen, but that's proving very tricky, so will do it as a separate PR, if at all)

[jcoyne]

I don't understand how this could have caused the failure:

  1) CatalogController index action with format :json facets should have items with labels and values
     Failure/Error: query_facet_items.first['label'].should == 'within 5 Years'
       expected: "within 5 Years"
            got: "within 10 Years" (using ==)
     # ./spec/controllers/catalog_controller_spec.rb:153:in `block (5 levels) in <top (required)>'

Perhaps the test data moved outside of a 5 year window?

[jrochkind]

Thanks @jcoyne, me neither. Literally all I changed was styles in a .css file, as can be verified by the diff. (Didn't even change any classes in the HTML or anything).

i suspect the next commit that isn't me will trigger the same failure, and presumably people could trigger it running the tests locally too?

[cbeer]

@jcoyne got it -- we only have test data up to 2008.

[jrochkind]

thanks @cbeer! I see you fixed in master, thanks again. I'll merge or rebase this branch (is rebasing preferred? It always scares me so).