No need to check for Turbolinks defined. #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there's no Turbolinks, we registered an event handler for an event that will never be hired -- this should not harm anything. But the check introduces possible order-of-load errors, where blacklight core accidentally ends up loaded before turbolinks, so doesn't set up the event handler, but then turbolinks loads later, so the event handler was needed, but didn't load. ran into this with an engine that inserted it's 'require x.js' before turbolinks. Best to avoid order-of-load dependencies if we can; we can.
jcoyne
added a commit
that referenced
this pull request
Feb 11, 2014
No need to check for Turbolinks defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's no Turbolinks, we registered an event handler
for an event that will never be fired -- this should not harm
anything.
But the check introduces possible order-of-load errors, where
blacklight core accidentally ends up loaded before turbolinks,
so doesn't set up the event handler, but then turbolinks loads later,
so the event handler was needed, but didn't load. ran into this
with an engine that inserted it's 'require x.js' before turbolinks.
Best to avoid order-of-load dependencies if we can; we can.