ajax_modal: Combine trigger and preserve selectors #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in one event handler registration, so if something matches both trigger and preserve selectors, it still only gets one event handler call, not two. Fixes #772 Needs to be backported to a 5.0.2 release as a bugfix.
|
👍 |
|
wait, don't merge yet. I realized my fix is not good enough. Bah! |
since you can list multiple selectors, they each need to be manually listed as scoped inside the dialog, just string-prefixing the ancestor wasn't going to work. Plus better comment docs.
|
Okay, ready for merging as far as i'm concerned. Both commits fix bugs and should prob be backported. |
jcoyne
added a commit
that referenced
this pull request
Feb 12, 2014
ajax_modal: Combine trigger and preserve selectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...in one event handler registration, so if something matches both
trigger and preserve selectors, it still only gets one event handler
call, not two. Fixes #772
Needs to be backported to a 5.0.2 release as a bugfix.