New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch etcd mode to use an init container for CNI #2300

Merged
merged 1 commit into from Nov 19, 2018

Conversation

Projects
None yet
4 participants
@caseydavenport
Copy link
Member

caseydavenport commented Nov 18, 2018

Description

We did this for KDD a while back and it seems to be working well. Let's do it for etcd in the same release.

#2231

Todos

  • Tests
  • Documentation
  • Release note

Release Note

etcd manifests now install CNI plugins and config using an init container

@caseydavenport caseydavenport requested a review from projectcalico/core-maintainers as a code owner Nov 18, 2018

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Nov 18, 2018

CLA assistant check
All committers have signed the CLA.

@caseydavenport

This comment has been minimized.

Copy link
Member

caseydavenport commented Nov 18, 2018

Deploy preview for calico ready!

Built with commit 567d982

https://deploy-preview-2300--calico.netlify.com

@caseydavenport caseydavenport force-pushed the caseydavenport:init-container branch from bbe923a to 2e02cb1 Nov 18, 2018

@caseydavenport caseydavenport force-pushed the caseydavenport:init-container branch from 2e02cb1 to 567d982 Nov 18, 2018

@caseydavenport caseydavenport requested a review from fasaxc Nov 18, 2018

@neiljerram neiljerram changed the title Switch etcd mode to use an init contianer for CNI Switch etcd mode to use an init container for CNI Nov 19, 2018

@neiljerram
Copy link
Member

neiljerram left a comment

LGTM. I'm not really a manifest expert, but I did a fairly careful check against what we had before for etcd CNI setup as a non-init container, and I don't think anything has been lost.

@fasaxc

This comment has been minimized.

Copy link
Member

fasaxc commented Nov 19, 2018

ISTR that we used to keep the container running so it monitored the etcd certs, or something? What are we losing here?

@caseydavenport

This comment has been minimized.

Copy link
Member

caseydavenport commented Nov 19, 2018

@fasaxc yeah, we're losing that bit of logic where if the cert changed we'd copy it across to the host.

I don't think it's useful - you need to restart felix / confd / etc anyway if the certs change, so my thinking was you'll need to restart this pod anyway.

WDYT?

@caseydavenport caseydavenport added this to the Calico v3.4.0 milestone Nov 19, 2018

@caseydavenport caseydavenport merged commit a4fa5b3 into projectcalico:master Nov 19, 2018

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@caseydavenport caseydavenport deleted the caseydavenport:init-container branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment