Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding -bird-live option to the liveness check #3011

Merged
merged 1 commit into from Nov 26, 2019

Conversation

asincu
Copy link
Contributor

@asincu asincu commented Nov 25, 2019

Description

Adding a check for bird and confd as part of the liveness check

Related issues/PRs

fixes #2889
projectcalico/node#369

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Adding -bird-live/-bird6-live option to check for bird, bird6 and conf as part of the liveness probe.

@marvin-tigera marvin-tigera added docs-pr-required Change is not yet documented release-note-required Change has user-facing impact (no matter how small) labels Nov 25, 2019
@asincu asincu changed the title Adding -bird-live Adding -bird-live option to the liveness check Nov 25, 2019
@CLAassistant
Copy link

CLAassistant commented Nov 25, 2019

CLA assistant check
All committers have signed the CLA.

@caseydavenport
Copy link
Member

caseydavenport commented Nov 25, 2019

Deploy preview for calico ready!

Built with commit 094e15a

https://deploy-preview-3011--calico.netlify.com

Copy link
Member

@matthewdupre matthewdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, although I'm slightly nervous that we're switching from GET /liveness to exec in 3.8 and 3.9. The code change to node went in for those versions though, so LGTM.

Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't merge the non-master ones yet

@caseydavenport
Copy link
Member

These will go live as soon as we merge, so we need to make the non-master changes after we cut the patch releases.

It's a sad consequence of how we do manifest generation today.

@caseydavenport
Copy link
Member

@asincu could you pull out the master changes into their own PR?

@caseydavenport caseydavenport added docs-not-required Docs not required for this change and removed docs-pr-required Change is not yet documented labels Nov 26, 2019
@asincu
Copy link
Contributor Author

asincu commented Nov 26, 2019

@caseydavenport I will open a new PR with the changes for 3.8, 3.9 and 3.10.

Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@caseydavenport caseydavenport merged commit 67cb745 into projectcalico:master Nov 26, 2019
@caseydavenport caseydavenport added release-note-not-required Change has no user-facing impact and removed release-note-required Change has user-facing impact (no matter how small) labels Mar 31, 2020
caseydavenport pushed a commit that referenced this pull request Dec 14, 2021
…s-master

[master] Semaphore Auto Pin Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve calico-node liveness probe to detect bird or confd not running
5 participants