New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding -bird-live option to the liveness check #3011
Conversation
Deploy preview for calico ready! Built with commit 094e15a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, although I'm slightly nervous that we're switching from GET /liveness to exec in 3.8 and 3.9. The code change to node went in for those versions though, so LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't merge the non-master ones yet
These will go live as soon as we merge, so we need to make the non-master changes after we cut the patch releases. It's a sad consequence of how we do manifest generation today. |
@asincu could you pull out the |
@caseydavenport I will open a new PR with the changes for 3.8, 3.9 and 3.10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…s-master [master] Semaphore Auto Pin Update
Description
Adding a check for bird and confd as part of the liveness check
Related issues/PRs
fixes #2889
projectcalico/node#369
Todos
Release Note