Adjust how kube-controllers timeout works #6610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
docs-pr-required
caseydavenport
commented
Aug 24, 2022
| @@ -88,7 +88,7 @@ The default values.yaml should be suitable for most basic deployments. | |||
|
|
|||
| ``` | |||
| # Image pull secrets to provision for pulling images from private registries. | |||
| # If provided, references to the secrets must also be provided in the installation section. | |||
There was a problem hiding this comment.
Whoops, this is unrelated but still good to merge 😅
Josh-Tigera
reviewed
Aug 24, 2022
Josh-Tigera
reviewed
Aug 24, 2022
caseydavenport
commented
Aug 24, 2022
| @@ -261,9 +266,10 @@ func runHealthChecks(ctx context.Context, s *status.Status, k8sClientset *kubern | |||
| // carry on | |||
| } | |||
|
|
|||
| // skip healthchecks if configured | |||
| // Datastore HealthCheck | |||
| healthCtx, cancel := context.WithTimeout(ctx, 10*time.Second) | |||
There was a problem hiding this comment.
Maybe we should have two different timeouts - EnsureInitialized can potentially make a few HTTP calls under the hood.
Josh-Tigera
approved these changes
Aug 24, 2022
mgleung
approved these changes
Aug 24, 2022
caseydavenport
force-pushed
the
casey-fix-kc-health
branch
from
eabcbec
to
7ee3e2b
Compare
caseydavenport
added
docs-not-required
3 tasks
caseydavenport
added a commit
that referenced
this pull request
Aug 26, 2022
…n-release-v3.24 [release-v3.24] Auto pick #6610: Adjust how kube-controllers timeout works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.