Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finesse health reports, actually print the table not its string. #6833

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

fasaxc
Copy link
Member

@fasaxc fasaxc commented Oct 11, 2022

Description

Noticed that the nicely formatted table of health reports was being printed as a JSON-encoded string, making it completely unreadable. Fix that up along with another small niggle; the health report changed log was printing confusing output that made it look like a readiness-only health report was non-live.

New output:

2022-10-11 14:24:42.376 [INFO][98] felix/health.go 263: Overall health status changed: live=true ready=true
+---------------------------+---------+----------------+-----------------+--------+
|         COMPONENT         | TIMEOUT |    LIVENESS    |    READINESS    | DETAIL |
+---------------------------+---------+----------------+-----------------+--------+
| async_calc_graph          | 20s     | reporting live | reporting ready |        |
| egress-networking-in-sync | 0s      | -              | reporting ready |        |
| felix-startup             | 0s      | reporting live | reporting ready |        |
| int_dataplane             | 1m30s   | reporting live | reporting ready |        |
| l7_reporter               | 20s     | reporting live | reporting ready |        |
+---------------------------+---------+----------------+-----------------+--------+

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Improve formatting of logged-out health reports from components such as Felix.

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@fasaxc fasaxc requested a review from a team as a code owner October 11, 2022 14:44
@marvin-tigera marvin-tigera added this to the Calico v3.25.0 milestone Oct 11, 2022
@marvin-tigera marvin-tigera added docs-pr-required Change is not yet documented release-note-required Change has user-facing impact (no matter how small) labels Oct 11, 2022
@fasaxc fasaxc added docs-not-required Docs not required for this change and removed docs-pr-required Change is not yet documented labels Oct 11, 2022
@fasaxc fasaxc merged commit 2d84498 into projectcalico:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants