Skip setting node IP annotation if CALICO_NETWORKING_BACKEND=none #7550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
|
/sem-approve |
|
@skmatti it appears that a formatting check didn't pass on our end. Could I get you to run |
`projectcalico.org/IPv4Address` and `projectcalico.org/IPv4IPIPTunnelAddr` annotations are used for BGP so disabling these in `policy` only mode
|
@mgleung Thanks for review. I have updated the PR with formatting fixed. |
|
/sem-approve |
|
Sorry for the delay @skmatti and thanks for the contribution! |
3 tasks
skmatti
added a commit
to skmatti/calico
that referenced
this pull request
May 29, 2023
`projectcalico.org/IPv4Address` and `projectcalico.org/IPv4IPIPTunnelAddr` annotations are used for BGP so disabling these in `policy` only mode Cherrypicks projectcalico#7550 Change-Id: I4afc43f5c2306a2bd93ecb45876cdb5854aedb50
skmatti
added a commit
to skmatti/calico
that referenced
this pull request
May 29, 2023
Followup to projectcalico#7550 Bug: 237698160 Change-Id: I185a179df725d4f113abe966c4dfc5f27fd521d8
skmatti
added a commit
to skmatti/calico
that referenced
this pull request
May 29, 2023
Followup to projectcalico#7550 Change-Id: Icb738cf2d2f84c175812ac12b31c95f63139fe31
skmatti
added a commit
to skmatti/calico
that referenced
this pull request
May 30, 2023
Followup to projectcalico#7550 Change-Id: I01c8018c9d47401383f05861865ff0c9b44c506e
skmatti
added a commit
to skmatti/calico
that referenced
this pull request
May 30, 2023
Followup to projectcalico#7550 Change-Id: I01c8018c9d47401383f05861865ff0c9b44c506e
tobiasgiese
pushed a commit
to mercedes-benz/calico
that referenced
this pull request
Jun 29, 2023
Followup to projectcalico#7550 Change-Id: I01c8018c9d47401383f05861865ff0c9b44c506e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
projectcalico.org/IPv4Addressandprojectcalico.org/IPv4IPIPTunnelAddrannotations are used for BGP so disabling these inpolicyonly modeIf we remove this dependency, calico-node in policy only mode does not need k8s node update/ patch permissions which addresses a vulnerability associated with node agent's over provisioned permissions.
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.