Fix nilpointer if CALICO_NETWORKING_BACKEND=none #7821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
tobiasgiese
force-pushed
the
tobiasgiese/fix-nilpointer-policyonly
branch
from
8723de1
to
18c6886
Compare
|
IMO this PR needs no release notes and no docs |
tobiasgiese
force-pushed
the
tobiasgiese/fix-nilpointer-policyonly
branch
2 times, most recently
from
d3910ca
to
c794a32
Compare
There is a nil pointer in the configureASNumber function if the networking backend is none (i.e. policy-only mode) Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
tobiasgiese
force-pushed
the
tobiasgiese/fix-nilpointer-policyonly
branch
from
c794a32
to
3740b39
Compare
caseydavenport
approved these changes
Jun 28, 2023
|
/sem-approve |
|
@caseydavenport do you know why the Calico test has failed? Clicking Details results in a 404 for me |
|
1 testcase failure: |
This was referenced Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a nil pointer in the configureASNumber function if the networking backend is none (i.e. policy-only mode). Followup to #7714
Related issues/PRs
Part of #7819
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.Tobias Giese tobias.giese@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, legal info/Impressum