OpenStack packaging updates & Jammy support #7622
Conversation
danudey
added
release-note-required
hack/release/packaging/docker-build-images/ubuntu-jammy-build.Dockerfile.amd64
Outdated
Show resolved
Hide resolved
hack/release/packaging/utils/lib.sh
Outdated
| @@ -1,3 +1,5 @@ | |||
| #!/bin/bash | |||
|
|
|||
There was a problem hiding this comment.
This file is designed only to be included (with . or source), not to be executed in its own right. That's why I didn't have that hashbang line before, and I think it's better to stay as it was.
There was a problem hiding this comment.
The purpose for adding the shebang line is to be able to parse the file correctly with shellcheck. I haven't done a full linting pass on these files, but I intend to do so in the future, so that's why this line was added. If you think it's a better idea to leave it unchanged though, I'll revert this.
There was a problem hiding this comment.
I don't want to impose my view here, but I do think it's wrong for tools to drive an incorrect agenda. Perhaps there's another way to tell shellcheck that this is a file that it should check?
There was a problem hiding this comment.
Hmm. I'll back this out for now, and then we can figure out the best solution for this when an actual linting pass happens.
Update to our Openstack packaging system: * Add support for Ubuntu Jammy amd64 and ppc64le * Fix build-deps for Ubuntu Focal/Jammy * Clean up CentOS 7 ppc64le builds * Convert build image creation to use `docker buildx bake` (see https://docs.docker.com/build/bake/) * Clean up build output
[Release 3.26] OpenStack packaging updates & Jammy support (cherry-pick #7622)
Description
A revamp of the existing packaging support for OpenStack
docker buildx bakewhich can build multiple images in parallelRelease Note