Fix panic in 'calicoctl get nodes' #7858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coutinhop
added
release-note-required
Fix panic when bgpConfig.Spec.ASNumber was nil in calicoctl/calicoctl/commands/common/printer.go (used by calicoctl/calicoctl/resourcemgr/node.go when running 'calicoctl get nodes', projectcalico#7755 for more info). Add printer config() test to calicoctl/calicoctl/commands/common/printer_test.go. Run ginkgo bootstrap in calicoctl/calicoctl/commands/common/ (tests were not being run previously). Consider $(GINKGO_ARGS) when running the 'ut' target in calicoctl/Makefile.
coutinhop
force-pushed
the
pedro-fix-calicoctl-panic
branch
from
9866a54
to
9026750
Compare
sridhartigera
approved these changes
Jul 12, 2023
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix panic when
bgpConfig.Spec.ASNumberwasnilin calicoctl/calicoctl/commands/common/printer.go (used by calicoctl/calicoctl/resourcemgr/node.go when running 'calicoctl get nodes', #7755 for more info).Add printer config() test to calicoctl/calicoctl/commands/common/printer_test.go.
Run
ginkgo bootstrapin calicoctl/calicoctl/commands/common/ (those tests were not being run previously).Consider $(GINKGO_ARGS) when running the
uttarget in calicoctl/Makefile.Description
Related issues/PRs
Fixes #7755
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.