Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic in 'calicoctl get nodes' #7858

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Fix panic in 'calicoctl get nodes' #7858

merged 1 commit into from
Jul 12, 2023

Commits on Jul 12, 2023

  1. Fix panic in 'calicoctl get nodes' 

    Fix panic when bgpConfig.Spec.ASNumber was nil in calicoctl/calicoctl/commands/common/printer.go (used by calicoctl/calicoctl/resourcemgr/node.go when running 'calicoctl get nodes', projectcalico#7755 for more info).

Add printer config() test to calicoctl/calicoctl/commands/common/printer_test.go.

Run ginkgo bootstrap in calicoctl/calicoctl/commands/common/ (tests were not being run previously).

Consider $(GINKGO_ARGS) when running the 'ut' target in calicoctl/Makefile.
    @coutinhop
    coutinhop committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9026750 View commit details
    Browse the repository at this point in the history