Update Typha Deployment tolerations to helm charts so that it can be scheduled on any node #7979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow typha deployment to tolerate the taint set via kubelet when used with --cloud-provider=external flag. We need typha to be able to schedule as soon as possible on new nodes since calico-node relies on it. Related Slack thread: https://calicousers.slack.com/archives/C0BCA117T/p1693469918340899
marvin-tigera
added
release-note-required
|
I think Typha and calico-node should have the exact same Tolerations since calico-node requires Typha to be up to come up itself. Can a core-maintainer confirm that position please? |
lwr20
reviewed
Sep 1, 2023
Co-authored-by: Lance Robson <lance@tigera.io>
ffilippopoulos
added a commit
to utilitywarehouse/calico-manifests
that referenced
this pull request
Sep 4, 2023
ffilippopoulos
added a commit
to utilitywarehouse/calico-manifests
that referenced
this pull request
Sep 4, 2023
* Allow calico-typha Deployment to be scheduled on all nodes projectcalico/calico#7979 * Schedule calico-typha on master nodes
coutinhop
added
docs-not-required
|
/sem-approve |
|
@lwr20 @coutinhop anything else we need from this prior to merge? The one thing I can see is that tests are failing - @ffilippopoulos you need to run |
I don't think so, @lwr20 please correct me if I'm wrong. |
|
/sem-approve |
coutinhop
changed the title
This was referenced Sep 28, 2023
coutinhop
added a commit
that referenced
this pull request
Sep 28, 2023
…elease-v3.26 [release-v3.26] Auto pick #7979: Typha tolerate
coutinhop
added a commit
that referenced
this pull request
Sep 28, 2023
…elease-v3.25 [release-v3.25] Auto pick #7979: Typha tolerate
coutinhop
added a commit
that referenced
this pull request
Sep 28, 2023
…elease-v3.24 [release-v3.24] Auto pick #7979: Typha tolerate
3 tasks
ilia1243
added a commit
to Netcracker/KubeMarine
that referenced
this pull request
Nov 27, 2023
koryaga
pushed a commit
to Netcracker/KubeMarine
that referenced
this pull request
Nov 28, 2023
… check (#551) * Clarify requirements for opened TCP ports * Major rework in network connectivity checks 1. Clarified listened and target ports for each node role. 2. Added UDP ports check (53 CoreDNS) 3. Connect each to each node. 4. Do not skip check if some node does not have python, or some ports are already listened. 5. Make connection attempts in parallel. 6. Only connect to listened ports or container ports instead of sending random stream of bytes. * Implement checking connectivity to VRRP IP * Update Installation.md * Fix floating issue at port listeners startup If the process is exited just after first failed attempt to read from pipe, the output is not checked and the connectivity check is terminated with error. The solution is to check if the process is exited first. * Calico Typha can be deployed on control planes projectcalico/calico#7979 --------- Co-authored-by: Shoaib Mohammed <94443646+shmo1218@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow typha deployment to tolerate the taint set via kubelet when used with --cloud-provider=external flag. We need typha to be able to schedule as soon as possible on new nodes since calico-node relies on it.
Related issues/PRs
Related Slack thread:
https://calicousers.slack.com/archives/C0BCA117T/p1693469918340899
Todos
Someone should run the respective make target to generate manifests picking up this change.
Release Note