Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v3.25] Auto pick #7979: Typha tolerate #8066

Conversation

coutinhop
Copy link
Contributor

Cherry pick of #7979 on release-v3.25.

#7979: Typha tolerate

Original PR Body below

Description

Allow typha deployment to tolerate the taint set via kubelet when used with --cloud-provider=external flag. We need typha to be able to schedule as soon as possible on new nodes since calico-node relies on it.

Related issues/PRs

Related Slack thread:
https://calicousers.slack.com/archives/C0BCA117T/p1693469918340899

Todos

Someone should run the respective make target to generate manifests picking up this change.

Release Note

Update Typha Deployment tolerations to helm charts so that it can be scheduled on any node.

ffilippopoulos and others added 3 commits September 28, 2023 09:01
Allow typha deployment to tolerate the taint set via kubelet when used with
--cloud-provider=external flag. We need typha to be able to schedule as
soon as possible on new nodes since calico-node relies on it.
Related Slack thread:
https://calicousers.slack.com/archives/C0BCA117T/p1693469918340899
Co-authored-by: Lance Robson <lance@tigera.io>
@coutinhop coutinhop requested a review from a team as a code owner September 28, 2023 16:02
@coutinhop coutinhop added release-note-required Change has user-facing impact (no matter how small) docs-not-required Docs not required for this change labels Sep 28, 2023
@marvin-tigera marvin-tigera added this to the Calico v3.25.3 milestone Sep 28, 2023
@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for calico-v3-25 canceled.

Name Link
🔨 Latest commit 9a89270
🔍 Latest deploy log https://app.netlify.com/sites/calico-v3-25/deploys/6515a379c187180008d9b63c

@coutinhop coutinhop merged commit ae49cf6 into projectcalico:release-v3.25 Sep 28, 2023
6 checks passed
@coutinhop coutinhop deleted the auto-pick-of-#7979-upstream-release-v3.25 branch September 28, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required Docs not required for this change release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants