-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-10546] Change rpm install order to fix 'undefined symbol: xtables_strdup' #9022
Conversation
…es_strdup' `microdnf install iproute-tc nftables` would install `iptables-libs` 1.8.5-11.el8_9 as a dependency, and it provides `/lib64/libxtables.so.12.3.0`. When using that `.so` file with `LD_PRELOAD`, we can consistently reproduce the issue: ``` LD_PRELOAD=/lib64/libxtables.so.12.3.0 iptables-legacy-save iptables-legacy-save: symbol lookup error: iptables-legacy-save: undefined symbol: xtables_strdup ``` The problem was, during our build process, we build iptables (and iptables-libs) v1.8.8 and install with `rpm --force`, but that doesn´t remove the outdated v1.8.5. By moving things around in the Dockerfiles and installing iptables-libs 1.8.8 before iproute-tc and nftables, the problematic 1.8.5 package is no longer installed and thus the correct `.so` file should be used (`libxtables.so.12.6.0` at the time of writing this).
I can confirm that this resolves the issue with |
node/Dockerfile.amd64
Outdated
# Install compatible libnftnl version with selected iptables version | ||
rpm -i /tmp/rpms/iptables-legacy-${IPTABLES_VER}.el8.2.x86_64.rpm && \ | ||
# Install iptables-libs via rpm. The libs must installed before installing iproute-tc and nftables via 'microdnf install' | ||
# otherwise they will pull an outdated version of iptables-libs (1.8.5-11.el8_9) as a dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.8.5-11.el8_9
version number may change in the future. This comment can get outdated soon-ish. Maybe we can remove the version? How do we handle future cases when iptables-libs
from the system repository is newer than what we build (1.8.8)?
RUN microdnf --enablerepo=baseos install iproute-tc nftables | ||
|
||
# Install iptables via rpm. Install compatible libnftnl version with the selected iptables version | ||
RUN rpm --force -i /tmp/rpms/libnftnl-${LIBNFTNL_VER}.el8.aarch64.rpm && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove --force
?
microdnf install iproute-tc nftables
would installiptables-libs
1.8.5-11.el8_9 as a dependency, and it provides/lib64/libxtables.so.12.3.0
. When using that.so
file withLD_PRELOAD
, we can consistently reproduce the issue:The problem was, during our build process, we build iptables (and iptables-libs) v1.8.8 and install with
rpm --force
, but that doesn´t remove the outdated v1.8.5. By moving things around in the Dockerfiles and installing iptables-libs 1.8.8 before iproute-tc and nftables, the problematic 1.8.5 package is no longer installed and thus the correct.so
file should be used (libxtables.so.12.6.0
at the time of writing this).Description
Related issues/PRs
fixes #8831 (tentatively, pending user confirmation)
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*
label.docs-pr-required
: This change requires a change to the documentation that has not been completed yet.docs-completed
: This change has all necessary documentation completed.docs-not-required
: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*
label.release-note-required
: This PR has user-facing changes. Most PRs should have this label.release-note-not-required
: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate
: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr
: This PR is related to install and requires a corresponding change to the operator.