Fix containerID read during IPAM migration #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simão Reis <smnrsti@gmail.com>
|
|
caseydavenport
approved these changes
Jan 3, 2020
This was referenced Jan 6, 2020
caseydavenport
added
cherry-pick-completed
docs-not-required
and removed
cherry-pick-candidate
docs-pr-required
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix.
Fixes https://github.com/projectcalico/cni-plugin/issues/821
The host-local IPAM plugin writes the interface name in the file where the container IP is stored. The calico-ipam plugin needs to parse the file during a migration or else it'll try and always fail to create a handle.
Todos
Couldn't find any tests for this code path, if any of the reviewers can point me to an example I'd be happy to contribute one as well.
[ ] DocumentationRelease Note