Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect /var/lib/calico/mtu file #962

Merged
merged 2 commits into from Oct 26, 2020
Merged

Respect /var/lib/calico/mtu file #962

merged 2 commits into from Oct 26, 2020

Conversation

caseydavenport
Copy link
Member

@caseydavenport caseydavenport commented Oct 14, 2020 •
edited

Description

File gets written by Felix in this PR: projectcalico/felix#2511

Todos

  • Tests
  • Documentation
  • Release note

Release Note

CNI plugin respects the /var/lib/calico/mtu file for picking pod MTU

@marvin-tigera marvin-tigera added this to the Calico v3.17.0 milestone Oct 14, 2020
@caseydavenport caseydavenport mentioned this pull request Oct 14, 2020
Merged
7 tasks
fasaxc
fasaxc requested changes Oct 26, 2020
View reviewed changes
Copy link
Member

@fasaxc fasaxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits but looks good apart from that; sounds like you checked windows impact with Song

internal/pkg/utils/utils.go Outdated Show resolved Hide resolved
internal/pkg/utils/utils.go Outdated Show resolved Hide resolved
@caseydavenport caseydavenport merged commit 4fd4036 into projectcalico:master Oct 26, 2020
@caseydavenport caseydavenport deleted the casey-mtu-autodetect branch October 26, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fasaxc fasaxc fasaxc requested changes

Assignees
No one assigned
Labels
docs-not-required release-note-required
Projects
None yet
Milestone
Calico v3.17.0
3 participants
@caseydavenport @fasaxc @marvin-tigera