Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read/write timeout options for Typha connection. #1538

Merged
merged 1 commit into from
Aug 30, 2017

Conversation

fasaxc
Copy link
Member

@fasaxc fasaxc commented Aug 29, 2017

Description

Fixes #1537

Todos

  • Move pin back to projectcalico/typha repo once fix is merged to client.
  • Release note
  • Docs

Release Note

Fix that, in some cases, Felix wouldn't spot if it got disconnected from Typha (#1537)

Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

My only question is how did we decide on the default values - 30s / 10s.

They seem sensible enough though.

@fasaxc
Copy link
Member Author

fasaxc commented Aug 30, 2017

The read timeout is set to 3x the default Typha ping interval; I figure missing 3 pings (with no other traffic) is a pretty bad sign.

I don't have much to back up the choice of write timeout, except that it matches the existing connection timeout. I really don't expect writes to take very long at all since we only write a packet every 10s to respond to pings.

@fasaxc fasaxc merged commit edbf92e into projectcalico:master Aug 30, 2017
@fasaxc fasaxc deleted the typha-timeout branch August 30, 2017 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants