Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
#1945: Adding support for regular expression values for the Interface Exclude parameter #1980
This PR contains:
One outstanding question I have is what we want to allow for the validation of the field now that it allows regexp patterns (since it could support wildcard as well as other symbols).
Namely here in
For example, should we keep the current validation pattern but only allow the introduction of the wildcard symbol
referenced this pull request
Mar 14, 2019
Sorry, I've generated some rather fragmented review comments here, but I think what it adds up to is:
PTAL and let me know what you think.
@stevegaossou By the way, another thought: when working with Felix config parameters, there are generally a few related places to think about:
In this case, the libcalico-go field has no
which means that there is no detailed libcalico-go validation here. And it's probably too big a job to start adding that now.
(Yes, it's kinda poor that in principle we have config validation in both Felix and libcalico-go... It would be good to work towards improving that, but I think it's a big task.)
But the updates (2) and (3) will be needed too.
This was referenced
Mar 15, 2019
I've commented on the point about die-on-fail and using the default value. I think that if you agree, and follow through on that, it will significantly reduce the size of this change - so then I think it would make sense for me to review again (hopefully for the last time) after that change is done.