Normal policy support for host-* endpoints #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmm
commented
Mar 5, 2020
nelljerram
reviewed
Mar 6, 2020
There was a problem hiding this comment.
@lmm I think the shape of this is looking pretty good. I've made one specific comment. Apart from that, my concern is just to be sure about what we decided in the spec about:
- defaults
- ordering (applying workload policy before WHEP policy, for traffic from a workload to its own host, and meshing with the existing hardcoded rules)
- optionally deduplication (in the case where the same policy applies to the workload and the WHEP)
and then obviously making sure that the code reflects that, ideally with copious tests.
Not to cali-th-any-interface-at-all. (And similarly for the From direction.)
lmm
changed the title
fasaxc
requested changes
Mar 23, 2020
nelljerram
previously requested changes
Mar 24, 2020
- toEndForwardRules was updated with wrong rules - in the `fromOnly` case (for pre-DNAT) we use HostFromEndpointPfx not HostFromEndpointForwardPfx, so the end rules passed to the dispatch chain builder were incorrect.
lmm
force-pushed
the
lmm-all-hep-policy
branch
4 times, most recently
from
1c342e7
to
068aad0
Compare
fasaxc
requested changes
Apr 6, 2020
There was a problem hiding this comment.
We discussed the AoF case on slack so I think we got to the bottom of that (test is failing due to AoF policy applying at workload egress for WHEPs, but not HEPs).
Good emphasis on testing in this PR; with lots of test being upgraded to cover the new case. Well worth that effort, I think!
Found a few nits in the tests.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
*hostendpoints currently only support pre-DNAT global network policy. This PR will (eventually) add normal policy support for*hostendpoints.Some notes on semantics:
*hostendpoint and a "named" (e.g.eth0) hostendpoint exist, the named hostendpoint will be used. (This is existing behaviour and isn't changing here.)Todos
Release Note