Handle mismatched nodenames in etcd mode IPAM cleanup #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
caseydavenport
commented
Apr 14, 2020
| @@ -63,14 +63,14 @@ func (c *NodeController) OnUpdates(updates []bapi.Update) { | |||
| case bapi.UpdateTypeKVUpdated: | |||
| n := upd.KVPair.Value.(*apiv3.Node) | |||
|
|
|||
| if c.config.SyncLabels { | |||
There was a problem hiding this comment.
This change just makes sure we're always populating the nodemapper map (we're already always running the syncer.)
caseydavenport
force-pushed
the
casey-handle-mismatched-nodenames
branch
from
0145628
to
cb9e2a6
Compare
robbrockbank
suggested changes
Apr 14, 2020
caseydavenport
force-pushed
the
casey-handle-mismatched-nodenames
branch
2 times, most recently
from
b38afae
to
b15c86a
Compare
caseydavenport
force-pushed
the
casey-handle-mismatched-nodenames
branch
from
b15c86a
to
7a910e0
Compare
caseydavenport
force-pushed
the
casey-handle-mismatched-nodenames
branch
from
7a910e0
to
1e2e6b4
Compare
robbrockbank
approved these changes
Apr 15, 2020
robbrockbank
suggested changes
Apr 15, 2020
robbrockbank
approved these changes
Apr 15, 2020
caseydavenport
added a commit
to caseydavenport/kube-controllers
that referenced
this pull request
Apr 15, 2020
) * Handle mismatched nodenames in etcd mode IPAM cleanup * Add IPAM GC test for etcd mismatched nodenames * Don't do anything for nodes which don't have a k8s equivalent * Handle case where no Calico node exists for IPAM entry * Add some more IPAM GC FV tests * Review comments * Update go modules * More feedback
3 tasks
caseydavenport
added a commit
to caseydavenport/kube-controllers
that referenced
this pull request
Apr 15, 2020
) * Handle mismatched nodenames in etcd mode IPAM cleanup * Add IPAM GC test for etcd mismatched nodenames * Don't do anything for nodes which don't have a k8s equivalent * Handle case where no Calico node exists for IPAM entry * Add some more IPAM GC FV tests * Review comments * Update go modules * More feedback
caseydavenport
added a commit
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like our IPAM GC controller has a bug in etcd mode when the name
of the Node in Calico's etcd doesn't match the name of the node in the
Kubernetes API.
It causes the controller to wrongfully release IP addresses that should
not yet be released. This change updates the controller to map nodenames
from Calico node names to Kubernetes node names before doing the
existence check.
Todos
Release Note