Support a custom host for health server #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of forcing to listen on all interfaces we should give the possibility for the user to make the health server listen on a specific host/ip.
|
|
There was a problem hiding this comment.
@renan thanks for the PR!
This looks really good to me. I'm going to leave the final approval to @neiljerram
|
This appears to have no tests tho, and my limited knowledge of Golang prevents me from writing an integration test for it :/ |
|
@renan Yes, you're off the hook there, because we don't yet have any test for ServeHTTP at all. (I think I have a TODO for it somewhere.) |
This was referenced Mar 29, 2018
This was referenced Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of forcing to listen on all interfaces we should give the possibility for the user to make the health server listen on a specific host/IP.
Felix component should also be updated to support this flag.
Todos
[ ] Tests