Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include HealthHost in v3.FelixConfigurationSpec #849

Merged
merged 2 commits into from Apr 12, 2018
Merged

Include HealthHost in v3.FelixConfigurationSpec #849

merged 2 commits into from Apr 12, 2018

Conversation

renan
Copy link
Contributor

@renan renan commented Apr 10, 2018 •
edited by caseydavenport

Description

Continuation of #818, needed in order to bring this configuration into projectcalico/felix.

This also includes a small integration test to ensure the property is configurable.

Release note

Can now set the bind address for Felix health endpoints in the FelixConfiguration object

@renan renan force-pushed the HealthServer_SupportCustomHost branch from e16262b to 1c71fec Compare April 11, 2018 09:22
@renan renan mentioned this pull request Apr 11, 2018
Closed
1 task
caseydavenport
caseydavenport approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@caseydavenport caseydavenport merged commit 65d364d into projectcalico:master Apr 12, 2018
@caseydavenport caseydavenport added this to the Calico v3.2.0 milestone Apr 12, 2018
@renan renan deleted the HealthServer_SupportCustomHost branch April 12, 2018 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport caseydavenport approved these changes

Assignees
No one assigned
Labels
release-note-required
Projects
None yet
Milestone
Calico v3.2.0
2 participants
@renan @caseydavenport