Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum TLS version to v1.2 for improved security. #457

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

fasaxc
Copy link
Member

@fasaxc fasaxc commented Nov 17, 2020

Description

  • Remove maximum TLS version. Should no longer be needed.

  • Remove unneeded TLS config to set the RNG; the tls implementation
    already uses the secure RNG by default.

Todos

  • Unit tests (full coverage)
  • Integration tests (delete as appropriate) In plan/Not needed/Done
  • Documentation
  • Backport
  • Release note

Release Note

For improved security, the Typha/Felix API now requires TLS v1.2+.

* Remove maximum TLS version.  Should no longer be needed.

* Remove unneeded TLS config to set the RNG; the tls implementation
  already uses the secure RNG by default.
Copy link
Member

@nelljerram nelljerram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

With TLSv1.2 forced, we no longer get an error from Start(), it
is deferred until the first read.
@fasaxc fasaxc merged commit 02cb7ab into projectcalico:master Nov 17, 2020
fasaxc added a commit to fasaxc/typha that referenced this pull request Feb 11, 2021
Increase minimum TLS version to v1.2 for improved security.

(cherry picked from commit 02cb7ab)
fasaxc added a commit to fasaxc/typha that referenced this pull request Feb 11, 2021
Increase minimum TLS version to v1.2 for improved security.

(cherry picked from commit 02cb7ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants