chore: test flaky #1113
Closed
chore: test flaky #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czosel
reviewed
Jul 21, 2020
| @@ -336,6 +336,7 @@ def test_complete_multiple_instance_task_form_work_item_next( | |||
| snapshot.assert_match(result.data) | |||
|
|
|||
|
|
|||
| @pytest.mark.flaky(10, 9) | |||
There was a problem hiding this comment.
Does this mean "at least 9 successes in 10 runs"?
There was a problem hiding this comment.
Yeah, I just wanted to try out if flaky helps us in any way... But doesn't seem to be the case, we don't want any flakiness.
|
Is fixing the actual flaky behavior not feasible? |
I don't think the code is flaky itself, because the tested result data seems fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.