Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow canceling of case #142

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Allow canceling of case #142

merged 1 commit into from
Dec 5, 2018

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Dec 5, 2018 •
edited
Loading

Allows to withdraw from a case at any point. When withdrawal is allowed is specified by permission.
All not completed work items are canceled when case is canceled.

@sliverc sliverc requested a review from winged December 5, 2018 12:40
@sliverc
Copy link
Member Author

sliverc commented Dec 5, 2018

depends on fix in #143

winged
winged approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Generally, I think some documentation would be a good thing. But you said this is going to be done once it stabilized, so.. OK for me :)

Allow canceling of case
e52490c 
All not completed work items are canceled when case is canceled
@sliverc sliverc merged commit 40c0ea2 into projectcaluma:master Dec 5, 2018
@sliverc sliverc deleted the subworkflow branch December 5, 2018 13:41
@sliverc sliverc mentioned this pull request Feb 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winged winged winged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliverc @winged