Implement flexible format validators #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-dynaMIX
force-pushed
the
add_flexible_format_validators
branch
2 times, most recently
from
a1ead19
to
9660e82
Compare
winged
approved these changes
May 6, 2019
There was a problem hiding this comment.
I really like the declarative syntax. From my POV, go ahead with the rest of the implementation for the remaining types.
Minor nitpick for the docs: I'd add a comment noting that it's OK to overwrite the validate() method for more complex validations, and what you can do with it. (Along with the note to have a corresponding implementation in the frontend as well, of course)
|
The API looks great to me as well! 👍 |
open-dynaMIX
force-pushed
the
add_flexible_format_validators
branch
from
9660e82
to
533d02a
Compare
This commit adds flexible format validators. There is one new query: `all_format_validators` that enables querying all available format validators. A text- or textarea-question can have one or multiple format_validators assigned. When querying a question, there is a new `FormatValidatorsConnection`, containing all FormatValidator-objects assigned on the question. For this there is a new `QuestionValidator` that ensures, referenced format_validators exist. `translate_value()` has been moved to `core.utils`, as this is used in the `data_source`- and `form`-app. There is a new extension-point `format_validators.py`. When adding the tests for this, it became obvious, that there was something wrong with the parameters for `DataSource`. As I was touching those tests anyway, I fixed this as well. Added commented out extension volume to docker-compose.yml. Also added forgotten data_sources extension volume. Additionally this commit also cleans up the snapshots for document and question as there were quite a lot old unused snapshots. Closes projectcaluma#360
open-dynaMIX
force-pushed
the
add_flexible_format_validators
branch
from
533d02a
to
8011518
Compare
|
I've added the info about overriding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds flexible format validators.
There is one new query:
all_format_validatorsthat enables queryingall available format validators.
A text- or textarea-question can have one or multiple format_validators
assigned.
When querying a question, there is a new
FormatValidatorsConnection,containing all FormatValidator-objects assigned on the question.
For this there is a new
QuestionValidatorthat ensures, referencedformat_validators exist.
translate_value()has been moved tocore.utils, as this is used in thedata_source- andform-app.There is a new extension-point
format_validators.py.When adding the tests for this, it became obvious, that there was something
wrong with the parameters for
DataSource. As I was touching those testsanyway, I fixed this as well.
Added commented out extension volume to docker-compose.yml. Also added
forgotten data_sources extension volume.
Additionally this commit also cleans up the snapshots for document and
question as there were quite a lot old unused snapshots.
Closes #360