Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gfx release ww30 #11

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

jennycao
Copy link
Contributor

No description provided.

js0701 and others added 26 commits November 14, 2018 09:58
We found rbc is buggy on new 4.19 kernel

Change-Id: I7ddcbe36658daf827a195ccda76145c34e76665a
Tracked-On: None
Tests: no scrambled screen
Signed-off-by: Lin Johnson <johnson.lin@intel.com>
Signed-off-by: Cao Jenny <jenny.q.cao@intel.com>
This reverts commit 8475e7d.

Signed-off-by: Cao Jenny <jenny.q.cao@intel.com>
Signed-off-by: Jenny Cao <jenny.q.cao@intel.com>
This patch could cause a boot issue. revert it for time being
This reverts commit a1a5439.

Change-Id: I8030db728056341c638340725ce661791e7bf99f
Tracked-On:https://jira.devtools.intel.com/browse/OAM-73760
Tests: Compile sucessful for Android.
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Add null pointer checking and correct the array format for fixing
the issues found by kclocwork on https://kw-jenkins.ostc.intel.com/
job/AndroidKW181_pmr0_bxtp_ivi_acrn_stable_gordon_peak/8/artifact/
BuildData/HTML/kw_issues_GFXOpenSourceDisplay.html

Change-Id: Ie7b51975cd0c20062b5da089da3ce275b772c11b
Tracked-On: https://jira.devtools.intel.com/browse/OAM-76317
Tests: Compile sucessful for Android. Pass dev testing.
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Secure coding guidelines (and the reason Klocwork flagged this) state
that you should never assume multiple calls to a function will return
the same result, even if it is highly unlikely to change.

Change-Id: I710d34eeb767dcf5f83ba91bf637d1cf367f3baf
Tracked-On: https://jira.devtools.intel.com/browse/OAM-76669
Tests: Compile sucessful for Android.
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Fix ACRN build error caused by 37f472c

Change-Id: I224b4e475ff8a19e3ef989f3080c1b67dbfd433e
Tracked-On: https://jira.devtools.intel.com/browse/OAM-76800
Tests: Compile sucessful for ACRN and baremetal, all display mode works well.
Signed-off-by: HeYue <yue.he@intel.com>
Signed-off-by: Jenny Cao <jenny.q.cao@intel.com>
Checking if the buffer pointer is null before using it.

Change-Id: If2631bb5c28efc0f3e5951104a150c1464008277
Test: Compile sucessful for Android.
Tracked-On:https://jira.devtools.intel.com/browse/OAM-78892
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Use the method drmAuthMagic to check if hwc is already DRM master
or not.

Change-Id: I1931017e1223ae550c52816e6b2a64c74bdf9190
Tests: Work well on celadon with kernel 4.19.19
Tracked-On: None
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Merge branch 'upstream_ww24' into jenny/gfx_release_ww24

Tracked-On:OAM-83195
Signed-off-by: Jenny Cao <jenny.q.cao@intel.com>
Revert an old fix because it dosen't pass kw scan.
Fix kw issues in commit bee3746 base on 80 daily build.
The rest of issues will be set as ignored later.

Test: tested on APL
Tracked-On: https://jira.devtools.intel.com/browse/OAM-83338
Sighed-off-by: Yuanzhe, Liu <yuanzhe.liu@intel.com>
Change-Id: Ia6aa596b4dc4c83820910a2dd40a53f774c94508
Reviewed-on: https://android.intel.com:443/672875
Add a normal initialization statement.
Add a if statement to validate the variable.

Change-Id: Ibf5b5a68293ab8a9022bfb50f469c57918c58e51
Test: Boot DUT successful
Tracked-On: https://jira.devtools.intel.com/browse/OAM-83419
Sighed-off-by: Yuanzhe, Liu <yuanzhe.liu@intel.com>
Revert an old fix because it dosen't pass kw scan.
Fix kw issues in commit bee3746 base on 80 daily build.
The rest of issues will be set as ignored later.

Test: tested on APL
Tracked-On: No
Sighed-off-by: Yuanzhe, Liu <yuanzhe.liu@intel.com>
Change-Id: Ia6aa596b4dc4c83820910a2dd40a53f774c94508
The surface damage issue is fixed by AOSP patch
https://android.intel.com/#/c/672623/1
The WA is not needed any more
This reverts commit 95ec73b.

Change-Id: I5d675d20de486d688f43f09a5a292821184bc9ce
Tests: Work well with AOSP patch on Android Q
Tracked-On: None
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Kernel required the width and left of YUV video buffer must be
multiple of 2. when the width and left is odd. we should use AB24
format for video. and use VPP path.

Change-Id: I7d17533f8d2a1c086850b496659b65387908457e
Tests: On Android Q, the protected video can be shown, but not
       decoded correctly
Tracked-On: https://jira.devtools.intel.com/browse/OAM-82976
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Add a normal initialization statement.
Add a if statement to validate the variable.

Change-Id: I6eb23808d3e5e120f51c9274e0567c2ecd66f2a3
Test: Boot DUT successful
Tracked-On: https://jira.devtools.intel.com/browse/OAM-83372
Sighed-off-by: Yuanzhe, Liu <yuanzhe.liu@intel.com>
Once video is contained, use VPP to compose all layers instead
of OpenGL render

Change-Id: I4e5bafe34c691d8c4b8ed8526ba0f3d20619b082
Tests: Work on Android Q
Tracked-On: None
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
This is WA as APL NUC always triggers hotplug when resume from S3,
which causes the postpone mode set be ingnored and display can't
be resumed from blackscreen.

Change-Id: I49e66552b373f1adde7aa6d04a19c508adeab991
Test: Display can be resumed from S3 successfully.
Tracked-On: OAM-81142
Sighed-off-by: Yugang, Fan <yugang.fan@intel.com>
Asked by AOSP, only 2 display config should be return to SF
one is the preferred config. and the other is optional better
performance config.

Change-Id: I966bbdeb819e54b12a5ef37103e593207b95a940
Tests: Work well on Android Q GP
Tracked-On: https://jira.devtools.intel.com/browse/OAM-83748
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
Since only 2 displaymode (same resolution) will be reported to SF.
No need to remain the workaround for viewsonic display.
This reverts commit bee3746.
Conflicts:
	wsi/drm/drmdisplay.cpp
	wsi/drm/drmdisplay.h

Change-Id: If8ca324711c242517574b31c814fb93677690d2d
Tests: Work well on Android Q
Tracked-On: https://jira.devtools.intel.com/browse/OAM-83748
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
After create the layer surface with format AB24 for video or protected
layer. need to re-set the layer as Video.
also do not use RBC once the preferred modifier is 0.

Change-Id: Ic01b7069186d847d923af77ea257fb886f5429bb
Tests: Work well on Android Q
Tracked-On: https://jira.devtools.intel.com/browse/OAM-82976
Signed-off-by: Shaofeng Tang <shaofeng.tang@intel.com>
@jennycao jennycao requested a review from js0701 July 30, 2019 06:29
Tracked-On: OAM-84369

Signed-off-by: Jenny Cao <jenny.q.cao@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants