Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command line flag to allow specification of Ingress.status.Loadbalancer value #2387

Closed
youngnick opened this issue Mar 26, 2020 · 0 comments · Fixed by #2421
Closed

Add command line flag to allow specification of Ingress.status.Loadbalancer value #2387

youngnick opened this issue Mar 26, 2020 · 0 comments · Fixed by #2421
Assignees
@youngnick
Labels
area/ingress Issues or PRs related to the Ingress API. area/status Issues or PRs related to exposing status for APIs.

Comments

@youngnick
Copy link
Member

Once #2386 is merged, Ingress will be able to have a Service's contact details published to the status.Loadbalancer stanza, similarly to the Nginx ingress controller --publish-service command-line argument.

This issue covers adding a manual way to specify reachability info, which will cover many other use cases for now, similarly to the --publish-status-address command-line option to Nginx.

The flag should take a string and publish it straight into any relevant Ingress documents. Obviously, this should also mean the service discovery is disabled.
@youngnick youngnick added area/ingress Issues or PRs related to the Ingress API. area/status Issues or PRs related to exposing status for APIs. labels Mar 26, 2020
@youngnick youngnick self-assigned this Mar 26, 2020
This was referenced Mar 26, 2020
Closed
Merged
youngnick added a commit to youngnick/contour that referenced this issue Apr 8, 2020
@youngnick
cmd/contour: Add flag to specify status.loadbalancer address statically
7de20fa 
Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes projectcontour#2387
Updates projectcontour#403

Further documentation to come under projectcontour#403.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 8, 2020
@youngnick
cmd/contour: Add flag to specify status.loadbalancer address statically
38cbf75 
Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes projectcontour#2387
Updates projectcontour#403

Further documentation to come under projectcontour#403.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 8, 2020
@youngnick
cmd/contour: Add flag to specify status.loadbalancer address statically
80cb405 
Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes projectcontour#2387
Updates projectcontour#403

Further documentation to come under projectcontour#403.

Signed-off-by: Nick Young <ynick@vmware.com>
@youngnick youngnick mentioned this issue Apr 8, 2020
Merged
@michmike michmike added this to In progress in Contour Project Board Apr 14, 2020
youngnick added a commit to youngnick/contour that referenced this issue Apr 16, 2020
@youngnick
cmd/contour: Add flag to specify status.loadbalancer address statically
68de014 
Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes projectcontour#2387
Updates projectcontour#403

Further documentation to come under projectcontour#403.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 17, 2020
@youngnick
cmd/contour: Add flag to specify status.loadbalancer address statically
63a1f7c 
Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes projectcontour#2387
Updates projectcontour#403

Further documentation to come under projectcontour#403.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 17, 2020
@youngnick
cmd/contour: Add flag to specify status.loadbalancer address statically
5d757a5 
Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes projectcontour#2387
Updates projectcontour#403

Further documentation to come under projectcontour#403.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 17, 2020
@youngnick
cmd/contour: Add flag to specify status.loadbalancer address statically
76868c4 
Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes projectcontour#2387
Updates projectcontour#403

Further documentation to come under projectcontour#403.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick added a commit to youngnick/contour that referenced this issue Apr 20, 2020
@youngnick
cmd/contour: Add flag to specify status.loadbalancer address statically
1893a3a 
Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes projectcontour#2387
Updates projectcontour#403

Further documentation to come under projectcontour#403.

Signed-off-by: Nick Young <ynick@vmware.com>
Contour Project Board automation moved this from In progress to 1.4 release Apr 20, 2020
youngnick added a commit that referenced this issue Apr 20, 2020
@youngnick
cmd/contour: Add flag to specify status.loadbalancer address statical…
0853282 
…ly (#2421)

Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes #2387
Updates #403

Further documentation to come under #403.

Signed-off-by: Nick Young <ynick@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youngnick youngnick

Labels
area/ingress Issues or PRs related to the Ingress API. area/status Issues or PRs related to exposing status for APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/contour: Add flag to specify status.loadbalancer address statically youngnick/contour
1 participant
@youngnick