Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address not set on Ingress resource #403

Closed
nphmuller opened this issue May 18, 2018 · 16 comments · Fixed by #2454
Closed

Address not set on Ingress resource #403

nphmuller opened this issue May 18, 2018 · 16 comments · Fixed by #2454
Assignees
Labels
area/ingress Issues or PRs related to the Ingress API. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@nphmuller
Copy link

nphmuller commented May 18, 2018

Contour does not set the IP value on the Ingress resource. This value is necessary for services like ExternalDNS to work properly.

Version

The version that https://j.hept.io/contour-deployment-norbac produces. Atm:
docker.io/envoyproxy/envoy-alpine:v1.6.0
gcr.io/heptio-images/contour:master (pointing to b9ede01f025)

Repro

  1. Setup Contour in your cluster.
    kubectl apply -f kubectl apply -f https://j.hept.io/contour-deployment-norbac
  2. Deploy a simple service with Ingress rules.
    kubectl apply -f https://gist.githubusercontent.com/nphmuller/1c980c72e2119b1482e19eb619def08f/raw/10331f4bbc18abe36a0c8c841bf70ab04a38eb92/service-with-ingress.yaml
  3. (A) kubectl get ingress nginx
  4. (B) kubectl get ingress nginx -o yaml

Expected

A. ADDRESS column should have external IP of Contour load balancer service, but is empty.
B. status should have value:

status:
  loadBalancer:
    ingress:
    - ip: %External IP-of-Contour-LoadBalancer-service%

but has value:

status:
  loadBalancer: {}
@nphmuller nphmuller changed the title IP address not set on Ingress Address not set on Ingress resource May 18, 2018
@davecheney
Copy link
Contributor

davecheney commented May 18, 2018 via email

@piclemx
Copy link

piclemx commented Jun 1, 2018

@davecheney do you know if this will be done soon?

@davecheney
Copy link
Contributor

davecheney commented Jun 1, 2018 via email

@nphmuller
Copy link
Author

@davecheney Still appreciate all the effort! 👍

@davecheney davecheney added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 25, 2018
@davecheney
Copy link
Contributor

This should be possible to cover as part of the IngressRoute refactor. No ETA on a milestone.

@vorozhko
Copy link

Hi @davecheney,
do you have any update on the issue?

I am using external-dns with Ingress and it require ADDRESS field to be set otherwise it will not create DNS records.

@davecheney
Copy link
Contributor

I’m sorry I don’t have an eta when this issue will be worked on.

@davecheney davecheney added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. blocked/needs-design Categorizes the issue or PR as blocked because it needs a design document. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 27, 2019
@davecheney davecheney removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 13, 2019
@davecheney davecheney added this to the 1.0.0.beta.1 milestone Jun 18, 2019
@davecheney davecheney mentioned this issue Sep 2, 2019
1 task
@davecheney
Copy link
Contributor

I'm sorry to report that at this stage in the development freeze without a design we won't be able to deliver this for rc.2. Moving to the backlog for prioritisation after Contour 1.0

@davecheney davecheney modified the milestones: 1.0.0-rc.2, Backlog Oct 17, 2019
@jpeach jpeach added the area/ingress Issues or PRs related to the Ingress API. label Nov 12, 2019
@stevesloka stevesloka self-assigned this Nov 25, 2019
youngnick pushed a commit to youngnick/contour that referenced this issue Apr 16, 2020
Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes projectcontour#2387
Updates projectcontour#403

Further documentation to come under projectcontour#403.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick pushed a commit to youngnick/contour that referenced this issue Apr 17, 2020
Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes projectcontour#2387
Updates projectcontour#403

Further documentation to come under projectcontour#403.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick pushed a commit to youngnick/contour that referenced this issue Apr 17, 2020
Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes projectcontour#2387
Updates projectcontour#403

Further documentation to come under projectcontour#403.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick pushed a commit to youngnick/contour that referenced this issue Apr 17, 2020
Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes projectcontour#2387
Updates projectcontour#403

Further documentation to come under projectcontour#403.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick pushed a commit to youngnick/contour that referenced this issue Apr 20, 2020
Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes projectcontour#2387
Updates projectcontour#403

Further documentation to come under projectcontour#403.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick pushed a commit that referenced this issue Apr 20, 2020
…ly (#2421)

Adds the `--ingress-status-address` flag to specify what address should be added to Ingress `status.loadbalancer` stanza by Contour.

Setting this flag will disable the automatic Envoy service watching for those details.

Fixes #2387
Updates #403

Further documentation to come under #403.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick pushed a commit to youngnick/contour that referenced this issue Apr 22, 2020
Fixes projectcontour#403.

Updates the `--ingress-status-address`, `--envoy-service-name`, and `--envoy-service-namespace` flags to be also readable from the config file.

The `serveContext` fields needed to be exported in order for the export to work.

Updated some logging to ensure that you can tell easily which settings are in effect.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick pushed a commit to youngnick/contour that referenced this issue Apr 23, 2020
Fixes projectcontour#403.

Updates the `--ingress-status-address`, `--envoy-service-name`, and `--envoy-service-namespace` flags to be also readable from the config file.

The `serveContext` fields needed to be exported in order for the export to work.

Updated some logging to ensure that you can tell easily which settings are in effect.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick pushed a commit to youngnick/contour that referenced this issue Apr 23, 2020
Fixes projectcontour#403.

Updates the `--ingress-status-address`, `--envoy-service-name`, and `--envoy-service-namespace` flags to be also readable from the config file.

The `serveContext` fields needed to be exported in order for the export to work.

Updated some logging to ensure that you can tell easily which settings are in effect.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick pushed a commit to youngnick/contour that referenced this issue Apr 24, 2020
Fixes projectcontour#403.

Updates the `--ingress-status-address`, `--envoy-service-name`, and `--envoy-service-namespace` flags to be also readable from the config file.

The `serveContext` fields needed to be exported in order for the export to work.

Updated some logging to ensure that you can tell easily which settings are in effect.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick pushed a commit to youngnick/contour that referenced this issue Apr 24, 2020
Fixes projectcontour#403.

Updates the `--ingress-status-address`, `--envoy-service-name`, and `--envoy-service-namespace` flags to be also readable from the config file.

The `serveContext` fields needed to be exported in order for the export to work.

Updated some logging to ensure that you can tell easily which settings are in effect.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick pushed a commit to youngnick/contour that referenced this issue Apr 24, 2020
Fixes projectcontour#403.

Updates the `--ingress-status-address`, `--envoy-service-name`, and `--envoy-service-namespace` flags to be also readable from the config file.

The `serveContext` fields needed to be exported in order for the export to work.

Updated some logging to ensure that you can tell easily which settings are in effect.

Signed-off-by: Nick Young <ynick@vmware.com>
youngnick pushed a commit that referenced this issue Apr 24, 2020
Fixes #403.

Updates the `--ingress-status-address`, `--envoy-service-name`, and `--envoy-service-namespace` flags to be also readable from the config file.

The `serveContext` fields needed to be exported in order for the export to work.

Updated some logging to ensure that you can tell easily which settings are in effect.

Signed-off-by: Nick Young <ynick@vmware.com>
knrt10 added a commit to kinvolk/lokomotive that referenced this issue Jun 17, 2020
- Due to upstream issue in contour projectcontour/contour#403
  address field was not setting on ingress resource. We introduced a workaround in
  71c19e0.

- Previously we were explicily using `IngressHosts` to work with external-dns. Now since
  the upstream issue has been fixed in contour we have removed option field `IngressHosts`.

Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10 added a commit to kinvolk/lokomotive that referenced this issue Jun 17, 2020
- Due to upstream issue in contour projectcontour/contour#403
  address field was not setting on ingress resource. We introduced a workaround in 71c19e0.

- Previously we were explicily using `IngressHosts` to work with external-dns. Now since the upstream issue has been fixed in contour we have removed option field `IngressHosts`.

Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10 added a commit to kinvolk/lokomotive that referenced this issue Jun 17, 2020
- Due to upstream issue in contour projectcontour/contour#403
  address field was not setting on ingress resource.
  We introduced a workaround in 71c19e0.

- Previously we were explicily using `IngressHosts` to work with external-dns.
  Now since the upstream issue has been fixed in contour we have removed option field `IngressHosts`.

Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10 added a commit to kinvolk/lokomotive that referenced this issue Jun 18, 2020
Due to upstream issue in contour, address fiels was not setting on
ingress resource. We introduces a workaround to solve that issue.

Previously we were explicitly using `IngressHosts` to work with
external-dns. Now since the upstream issue has been fixed in contour we
have removed optional field `IngressHosts`.

See projectcontour/contour#403
and 71c19e0

Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10 added a commit to kinvolk/lokomotive that referenced this issue Jun 18, 2020
Due to upstream issue in contour, address fiedls were not setting on
ingress resource. We introduced a workaround to solve that issue.

Previously we were explicitly using `IngressHosts` to work with
external-dns. Now since the upstream issue has been fixed in contour we
have removed optional field `IngressHosts`.

See projectcontour/contour#403
and 71c19e0

Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10 added a commit to kinvolk/lokomotive that referenced this issue Jun 18, 2020
Due to upstream issue in contour, address fields were not setting on
ingress resource. We introduced a workaround to solve that issue.

Previously we were explicitly using `IngressHosts` to work with
external-dns. Now since the upstream issue has been fixed in contour we
have removed optional field `IngressHosts`.

See projectcontour/contour#403
and 71c19e0

Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10 added a commit to kinvolk/lokomotive that referenced this issue Jun 18, 2020
Due to upstream issue in contour, address fields were not setting on
ingress resource. We introduced a workaround to solve that issue.

Previously we were explicitly using `IngressHosts` to work with
external-dns. Now since the upstream issue has been fixed in contour we
have removed optional field `IngressHosts`.

Update ingress mainfest for Dex and Gangway. Added a new annotation
`external-dns.alpha.kubernetes.io/hostname`, for external-dns to
automatically create DNS entries

external-dns default source changed to ingress

See projectcontour/contour#403
and 71c19e0

Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10 added a commit to kinvolk/lokomotive that referenced this issue Jun 18, 2020
Due to upstream issue in contour, address fields were not setting on
ingress resource. We introduced a workaround to solve that issue.

Previously we were explicitly using `IngressHosts` to work with
external-dns. Now since the upstream issue has been fixed in contour we
have removed optional field `IngressHosts`.

See projectcontour/contour#403
and 71c19e0

Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10 added a commit to kinvolk/lokomotive that referenced this issue Jun 22, 2020
Due to upstream issue in contour, address fields were not setting on
ingress resource. We introduced a workaround to solve that issue.

Previously we were explicitly using `IngressHosts` to work with
external-dns. Now since the upstream issue has been fixed in contour we
have removed optional field `IngressHosts`.

See projectcontour/contour#403
and 71c19e0

Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10 added a commit to kinvolk/lokomotive that referenced this issue Jun 26, 2020
Due to upstream issue in contour, address fields were not setting on
ingress resource. We introduced a workaround to solve that issue.

Previously we were explicitly using `IngressHosts` to work with
external-dns. Now since the upstream issue has been fixed in contour we
have removed optional field `IngressHosts`.

See projectcontour/contour#403
and 71c19e0

Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10 added a commit to kinvolk/lokomotive that referenced this issue Jun 26, 2020
Due to upstream issue in contour, address fields were not setting on
ingress resource. We introduced a workaround to solve that issue.

Previously we were explicitly using `IngressHosts` to work with
external-dns. Now since the upstream issue has been fixed in contour we
have removed optional field `IngressHosts`.

See projectcontour/contour#403
and 71c19e0

Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10 added a commit to kinvolk/lokomotive that referenced this issue Jun 29, 2020
Due to upstream issue in contour, address fields were not setting on
ingress resource. We introduced a workaround to solve that issue.

Previously we were explicitly using `IngressHosts` to work with
external-dns. Now since the upstream issue has been fixed in contour we
have removed optional field `IngressHosts`.

See projectcontour/contour#403
and 71c19e0

Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10 added a commit to kinvolk/lokomotive that referenced this issue Jun 29, 2020
Due to upstream issue in contour, address fields were not setting on
ingress resource. We introduced a workaround to solve that issue.

Previously we were explicitly using `IngressHosts` to work with
external-dns. Now since the upstream issue has been fixed in contour we
have removed optional field `IngressHosts`.

See projectcontour/contour#403
and 71c19e0

Signed-off-by: knrt10 <kautilya@kinvolk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ingress Issues or PRs related to the Ingress API. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
10 participants